Skip to content

chore(managed-identities): rm unused config API path#12856

Draft
zhumin8 wants to merge 1 commit intomainfrom
rm-managed-identities-v1beta1
Draft

chore(managed-identities): rm unused config API path#12856
zhumin8 wants to merge 1 commit intomainfrom
rm-managed-identities-v1beta1

Conversation

@zhumin8
Copy link
Copy Markdown
Contributor

@zhumin8 zhumin8 commented Apr 20, 2026

Removing unused API path from config for managed-identities, so that it matches the generated code status.

v1beta1 of java-managed-identities was added to the generation_config.yaml as part of initial migration to hermetic build: 14b7346, but client library code for v1beta1 is not present in java-managed-identities/google-cloud-managed-identities dir. This is due to deep-copy-regex being too strict and does not copy /v1beta1 from staging dir to final output.

Expect generation workflow to remove sample code related to v1beta1.

For #12736
For googleapis/librarian#5370

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the v1beta1 proto path for the Managed Identities API from the generation configuration. I have no feedback to provide.

@zhumin8
Copy link
Copy Markdown
Contributor Author

zhumin8 commented Apr 20, 2026

hmm, we got no changed libraries

+ changed_libraries=
+ echo 'Changed libraries are: No changed library.'
Changed libraries are: No changed library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant