fix: Support Creation of JSON columns#16733
Open
waltaskew wants to merge 1 commit intogoogleapis:mainfrom
Open
fix: Support Creation of JSON columns#16733waltaskew wants to merge 1 commit intogoogleapis:mainfrom
waltaskew wants to merge 1 commit intogoogleapis:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds support for the JSON data type in the BigQuery SQLAlchemy dialect by implementing the visit_JSON method and adding a corresponding unit test. Feedback was provided to include a JSONB alias for better compatibility with models using PostgreSQL-specific types.
Comment on lines
+625
to
+626
| def visit_JSON(self, type_, **kw): | ||
| return "JSON" |
Contributor
There was a problem hiding this comment.
Consider adding an alias for JSONB to improve compatibility with models that use the JSONB type (e.g., those originally designed for PostgreSQL). Since BigQuery's JSON type is binary-optimized, it is the appropriate mapping for JSONB in this dialect.
def visit_JSON(self, type_, **kw):
return "JSON"
visit_JSONB = visit_JSON
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15761