Skip to content

chore: regenerate compute packages using gRPC service config #16751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jskeet wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

chore: regenerate compute packages using gRPC service config #16751

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6916b9
chore: regenerate google-cloud-compute with gRPC service config
jskeet Apr 21, 2026
2c3387d
chore: regenerate google-cloud-compute-v1beta with gRPC service config
jskeet Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/google-cloud-compute-v1beta/.repo-metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,6 @@
"name": "google-cloud-compute-v1beta",
"name_pretty": "Compute Engine",
"product_documentation": "https://cloud.google.com/compute/",
"release_level": "stable",
"release_level": "preview",
"repo": "googleapis/google-cloud-python"
}
4 changes: 2 additions & 2 deletions packages/google-cloud-compute-v1beta/README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
Python Client for Compute Engine
================================

|stable| |pypi| |versions|
|preview| |pypi| |versions|

`Compute Engine`_: delivers virtual machines running in Google's innovative data centers and worldwide fiber network. Compute Engine's tooling and workflow support enable scaling from single instances to global, load-balanced cloud computing. Compute Engine's VMs boot quickly, come with persistent disk storage, deliver consistent performance and are available in many configurations.

- `Client Library Documentation`_
- `Product Documentation`_

.. |stable| image:: https://img.shields.io/badge/support-stable-gold.svg
.. |preview| image:: https://img.shields.io/badge/support-preview-orange.svg
:target: https://github.com/googleapis/google-cloud-python/blob/main/README.rst#stability-levels
.. |pypi| image:: https://img.shields.io/pypi/v/google-cloud-compute-v1beta.svg
:target: https://pypi.org/project/google-cloud-compute-v1beta/
Expand Down
4 changes: 2 additions & 2 deletions packages/google-cloud-compute-v1beta/docs/README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
Python Client for Compute Engine
================================

|stable| |pypi| |versions|
|preview| |pypi| |versions|

`Compute Engine`_: delivers virtual machines running in Google's innovative data centers and worldwide fiber network. Compute Engine's tooling and workflow support enable scaling from single instances to global, load-balanced cloud computing. Compute Engine's VMs boot quickly, come with persistent disk storage, deliver consistent performance and are available in many configurations.

- `Client Library Documentation`_
- `Product Documentation`_

.. |stable| image:: https://img.shields.io/badge/support-stable-gold.svg
.. |preview| image:: https://img.shields.io/badge/support-preview-orange.svg
:target: https://github.com/googleapis/google-cloud-python/blob/main/README.rst#stability-levels
.. |pypi| image:: https://img.shields.io/pypi/v/google-cloud-compute-v1beta.svg
:target: https://pypi.org/project/google-cloud-compute-v1beta/
Expand Down
36 changes: 33 additions & 3 deletions ...-compute-v1beta/google/cloud/compute_v1beta/services/accelerator_types/transports/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,17 +148,47 @@ def _prep_wrapped_messages(self, client_info):
self._wrapped_methods = {
self.aggregated_list: gapic_v1.method.wrap_method(
self.aggregated_list,
default_timeout=None,
default_retry=retries.Retry(
initial=0.1,
maximum=60.0,
multiplier=1.3,
predicate=retries.if_exception_type(
core_exceptions.DeadlineExceeded,
core_exceptions.ServiceUnavailable,
),
deadline=600.0,
),
default_timeout=600.0,
Comment on lines +151 to +161
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The default_retry configuration includes core_exceptions.DeadlineExceeded in its predicate, but the deadline (total timeout) is set to 600.0, which is identical to the default_timeout (per-attempt timeout). This configuration effectively prevents retries on timeouts because the first attempt that hits the 600s limit will also reach the total retry deadline. To make retrying on DeadlineExceeded effective, the deadline should be greater than the default_timeout, or the default_timeout should be reduced.

client_info=client_info,
),
self.get: gapic_v1.method.wrap_method(
self.get,
default_timeout=None,
default_retry=retries.Retry(
initial=0.1,
maximum=60.0,
multiplier=1.3,
predicate=retries.if_exception_type(
core_exceptions.DeadlineExceeded,
core_exceptions.ServiceUnavailable,
),
deadline=600.0,
),
default_timeout=600.0,
client_info=client_info,
),
self.list: gapic_v1.method.wrap_method(
self.list,
default_timeout=None,
default_retry=retries.Retry(
initial=0.1,
maximum=60.0,
multiplier=1.3,
predicate=retries.if_exception_type(
core_exceptions.DeadlineExceeded,
core_exceptions.ServiceUnavailable,
),
deadline=600.0,
),
default_timeout=600.0,
client_info=client_info,
),
}
Expand Down
46 changes: 38 additions & 8 deletions ...le-cloud-compute-v1beta/google/cloud/compute_v1beta/services/addresses/transports/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,42 +149,72 @@ def _prep_wrapped_messages(self, client_info):
self._wrapped_methods = {
self.aggregated_list: gapic_v1.method.wrap_method(
self.aggregated_list,
default_timeout=None,
default_retry=retries.Retry(
initial=0.1,
maximum=60.0,
multiplier=1.3,
predicate=retries.if_exception_type(
core_exceptions.DeadlineExceeded,
core_exceptions.ServiceUnavailable,
),
deadline=600.0,
),
default_timeout=600.0,
client_info=client_info,
),
self.delete: gapic_v1.method.wrap_method(
self.delete,
default_timeout=None,
default_timeout=600.0,
client_info=client_info,
),
self.get: gapic_v1.method.wrap_method(
self.get,
default_timeout=None,
default_retry=retries.Retry(
initial=0.1,
maximum=60.0,
multiplier=1.3,
predicate=retries.if_exception_type(
core_exceptions.DeadlineExceeded,
core_exceptions.ServiceUnavailable,
),
deadline=600.0,
),
default_timeout=600.0,
client_info=client_info,
),
self.insert: gapic_v1.method.wrap_method(
self.insert,
default_timeout=None,
default_timeout=600.0,
client_info=client_info,
),
self.list: gapic_v1.method.wrap_method(
self.list,
default_timeout=None,
default_retry=retries.Retry(
initial=0.1,
maximum=60.0,
multiplier=1.3,
predicate=retries.if_exception_type(
core_exceptions.DeadlineExceeded,
core_exceptions.ServiceUnavailable,
),
deadline=600.0,
),
default_timeout=600.0,
client_info=client_info,
),
self.move: gapic_v1.method.wrap_method(
self.move,
default_timeout=None,
default_timeout=600.0,
client_info=client_info,
),
self.set_labels: gapic_v1.method.wrap_method(
self.set_labels,
default_timeout=None,
default_timeout=600.0,
client_info=client_info,
),
self.test_iam_permissions: gapic_v1.method.wrap_method(
self.test_iam_permissions,
default_timeout=None,
default_timeout=600.0,
client_info=client_info,
),
}
Expand Down
2 changes: 1 addition & 1 deletion ...oogle-cloud-compute-v1beta/google/cloud/compute_v1beta/services/advice/transports/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ def _prep_wrapped_messages(self, client_info):
self._wrapped_methods = {
self.calendar_mode: gapic_v1.method.wrap_method(
self.calendar_mode,
default_timeout=None,
default_timeout=600.0,
client_info=client_info,
),
}
Expand Down
46 changes: 38 additions & 8 deletions ...-cloud-compute-v1beta/google/cloud/compute_v1beta/services/autoscalers/transports/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,42 +149,72 @@ def _prep_wrapped_messages(self, client_info):
self._wrapped_methods = {
self.aggregated_list: gapic_v1.method.wrap_method(
self.aggregated_list,
default_timeout=None,
default_retry=retries.Retry(
initial=0.1,
maximum=60.0,
multiplier=1.3,
predicate=retries.if_exception_type(
core_exceptions.DeadlineExceeded,
core_exceptions.ServiceUnavailable,
),
deadline=600.0,
),
default_timeout=600.0,
client_info=client_info,
),
self.delete: gapic_v1.method.wrap_method(
self.delete,
default_timeout=None,
default_timeout=600.0,
client_info=client_info,
),
self.get: gapic_v1.method.wrap_method(
self.get,
default_timeout=None,
default_retry=retries.Retry(
initial=0.1,
maximum=60.0,
multiplier=1.3,
predicate=retries.if_exception_type(
core_exceptions.DeadlineExceeded,
core_exceptions.ServiceUnavailable,
),
deadline=600.0,
),
default_timeout=600.0,
client_info=client_info,
),
self.insert: gapic_v1.method.wrap_method(
self.insert,
default_timeout=None,
default_timeout=600.0,
client_info=client_info,
),
self.list: gapic_v1.method.wrap_method(
self.list,
default_timeout=None,
default_retry=retries.Retry(
initial=0.1,
maximum=60.0,
multiplier=1.3,
predicate=retries.if_exception_type(
core_exceptions.DeadlineExceeded,
core_exceptions.ServiceUnavailable,
),
deadline=600.0,
),
default_timeout=600.0,
client_info=client_info,
),
self.patch: gapic_v1.method.wrap_method(
self.patch,
default_timeout=None,
default_timeout=600.0,
client_info=client_info,
),
self.test_iam_permissions: gapic_v1.method.wrap_method(
self.test_iam_permissions,
default_timeout=None,
default_timeout=600.0,
client_info=client_info,
),
self.update: gapic_v1.method.wrap_method(
self.update,
default_timeout=None,
default_timeout=600.0,
client_info=client_info,
),
}
Expand Down
Loading
Loading