chore: add core-deps-from-source session to bigframes#16752
chore: add core-deps-from-source session to bigframes#16752chalmerlowe wants to merge 9 commits intomainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request implements the core_deps_from_source Nox session to test with core dependencies installed from source. Feedback includes correcting several repository URLs, batching the installation process for efficiency, and using consistent path formatting for relative directories.
I am having trouble creating individual review comments. Click here to see my feedback.
packages/bigframes/noxfile.py (940-946)
The repository URLs for the core dependencies are incorrect. Packages like google-auth, google-api-core, and proto-plus are hosted in their own dedicated repositories under the googleapis organization, not within the google-cloud-python repository. Attempting to install them from google-cloud-python with the specified subdirectories will fail. The suggested code uses the correct repository URLs.
core_dependencies_from_source = [
"googleapis-common-protos @ git+https://github.com/googleapis/python-api-common-protos",
"google-api-core @ git+https://github.com/googleapis/python-api-core",
"google-auth @ git+https://github.com/googleapis/google-auth-library-python",
"grpc-google-iam-v1 @ git+https://github.com/googleapis/python-iam",
"proto-plus @ git+https://github.com/googleapis/proto-plus-python",
]
packages/bigframes/noxfile.py (948-950)
Installing dependencies in a loop is inefficient as it invokes pip multiple times. Batching them into a single session.install call is faster. Additionally, Nox already logs installation commands, so the explicit print statement is redundant.
session.install(*core_dependencies_from_source, "--no-deps", "--ignore-installed")packages/bigframes/noxfile.py (954-955)
Use consistent path handling. Since scripts_path is a simple string and pathlib is used elsewhere, avoid os.path.join for these hardcoded relative paths to improve readability and consistency.
tests_path = "tests/unit"
third_party_tests_path = "third_party/bigframes_vendored"
|
Switching to draft until presubmits are green |
|
This comment is in error:
Each of these has been migrated to the google-cloud-python repository as individual packages in the packages directory. Please feel free to confirm this and make a note for yourself so that this comment does not get raised other PRs. Thanks. |
|
Thank you for the clarification, @chalmerlowe. I appreciate you pointing out that these packages have been migrated to the |
This PR adds the core_deps_from_source session to bigframes to test against core dependencies installed from source in the monorepo.