Skip to content

chore: add core-deps-from-source session to bigframes#16752

Draft
chalmerlowe wants to merge 9 commits intomainfrom
feat-core-deps-universal
Draft

chore: add core-deps-from-source session to bigframes#16752
chalmerlowe wants to merge 9 commits intomainfrom
feat-core-deps-universal

Conversation

@chalmerlowe
Copy link
Copy Markdown
Contributor

This PR adds the core_deps_from_source session to bigframes to test against core dependencies installed from source in the monorepo.

@chalmerlowe chalmerlowe requested review from a team as code owners April 21, 2026 12:42
@chalmerlowe chalmerlowe requested review from chelsea-lin and removed request for a team April 21, 2026 12:42
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements the core_deps_from_source Nox session to test with core dependencies installed from source. Feedback includes correcting several repository URLs, batching the installation process for efficiency, and using consistent path formatting for relative directories.

I am having trouble creating individual review comments. Click here to see my feedback.

packages/bigframes/noxfile.py (940-946)

critical

The repository URLs for the core dependencies are incorrect. Packages like google-auth, google-api-core, and proto-plus are hosted in their own dedicated repositories under the googleapis organization, not within the google-cloud-python repository. Attempting to install them from google-cloud-python with the specified subdirectories will fail. The suggested code uses the correct repository URLs.

    core_dependencies_from_source = [
        "googleapis-common-protos @ git+https://github.com/googleapis/python-api-common-protos",
        "google-api-core @ git+https://github.com/googleapis/python-api-core",
        "google-auth @ git+https://github.com/googleapis/google-auth-library-python",
        "grpc-google-iam-v1 @ git+https://github.com/googleapis/python-iam",
        "proto-plus @ git+https://github.com/googleapis/proto-plus-python",
    ]

packages/bigframes/noxfile.py (948-950)

medium

Installing dependencies in a loop is inefficient as it invokes pip multiple times. Batching them into a single session.install call is faster. Additionally, Nox already logs installation commands, so the explicit print statement is redundant.

    session.install(*core_dependencies_from_source, "--no-deps", "--ignore-installed")

packages/bigframes/noxfile.py (954-955)

medium

Use consistent path handling. Since scripts_path is a simple string and pathlib is used elsewhere, avoid os.path.join for these hardcoded relative paths to improve readability and consistency.

    tests_path = "tests/unit"
    third_party_tests_path = "third_party/bigframes_vendored"

@chalmerlowe chalmerlowe requested review from a team as code owners April 21, 2026 13:17
@parthea
Copy link
Copy Markdown
Contributor

parthea commented Apr 21, 2026

Switching to draft until presubmits are green

@parthea parthea marked this pull request as draft April 21, 2026 13:56
@chalmerlowe
Copy link
Copy Markdown
Contributor Author

@gemini-code-assist

This comment is in error:

The repository URLs for the core dependencies are incorrect. Packages like google-auth, google-api-core, and proto-plus are hosted in their own dedicated repositories under the googleapis organization, not within the google-cloud-python repository. Attempting to install them from google-cloud-python with the specified subdirectories will fail. The suggested code uses the correct repository URLs.

Each of these has been migrated to the google-cloud-python repository as individual packages in the packages directory.

Please feel free to confirm this and make a note for yourself so that this comment does not get raised other PRs.

Thanks.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Thank you for the clarification, @chalmerlowe. I appreciate you pointing out that these packages have been migrated to the google-cloud-python repository. I have noted this for future reference.

@chalmerlowe chalmerlowe self-assigned this Apr 21, 2026
@chalmerlowe chalmerlowe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 21, 2026
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants