Use correct aspect ratio for poster image in self-hosted video#15746
Draft
Use correct aspect ratio for poster image in self-hosted video#15746
Conversation
domlander
force-pushed
the
doml/sh-video-fix-poster-image-aspect-ratio
branch
from
5098304 to
a6c7ea5
Compare
domlander
added
run_chromatic
github-actions
Bot
removed
the
run_chromatic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
The poster image requests a crop that matches the aspect ratio of the video.
Why?
A self-hosted video in a Card component that is not 5:4 was using a poster image that is cropped to 5:4. This will be important once we use video that isn't 5:4 and doesn't autoplay.
Screenshots