feat: integrate credential manager#49
Open
michaelmalave wants to merge 32 commits intofeat/ruby-to-typescriptfrom
Open
feat: integrate credential manager#49michaelmalave wants to merge 32 commits intofeat/ruby-to-typescriptfrom
michaelmalave wants to merge 32 commits intofeat/ruby-to-typescriptfrom
Conversation
…nter:open/preview
…nforce c8 coverage on src/**/*.ts
…stored lib unit tests, components inventory, npm/GitHub Actions Dependabot, and plugin usage updates to README
…o netrc-parser reads them correctly
…ugh oclif’s this.debug
…feat/ruby-to-typescript-2
…etrc on Windows and .netrc elsewhere, matching netrc-parser
Co-authored-by: Katy Bowman <katy.bowman@salesforce.com> Signed-off-by: Michael Malave <michael.malave@salesforce.com>
…, use ux.stdout, stub browser opens via sinon, add nock init, switch to shared ESLint config, and align tsconfig/package.json with CLI
…indentation and camelcase issues in unit tests
…auto-generated command docs
…feat/ruby-to-typescript-3
…ger for token retrieval
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaced direct netrc parsing with the
heroku-credentials-managerfrom@heroku-cli/command@13.0.0-beta.1for token retrieval.Type of Change
Verification
All 72 tests pass with 80.23% coverage (meets 80% threshold).
Additional Context
@heroku-cli/commandfrom^12.2.0to^13.0.0-beta.1netrc-parserdependency (now handled by credential manager)HEROKU_API_KEYenv var → native keychain → netrc fallbackgetHerokuApiToken()is now async; commands updated to useawaitesmockas dev dependency for ESM module mocking in testsnetrc-path.ts,test-home-env.ts)paths.tstests to maintain coverage thresholdRelated Issue
Closes #W-22034106