Skip to content

Default image pulls to GHCR and harden registry host resolution#26

Open
Copilot wants to merge 9 commits intomainfrom
copilot/deploy-to-azure-using-github-actions
Open

Default image pulls to GHCR and harden registry host resolution#26
Copilot wants to merge 9 commits intomainfrom
copilot/deploy-to-azure-using-github-actions

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 18, 2026

  • Inspect current CI workflows and project verification commands
  • Add a minimal GitHub Actions workflow to deploy/verify on Azure Kubernetes Service (AKS)
  • Verify volume and ResourceCapsule functionality in the Azure workflow
  • Document required Azure/GitHub secrets and how to trigger the workflow
  • Re-run go test ./... and go build ./... after changes

Copilot finished work on behalf of j143 April 18, 2026 11:50
Copilot AI requested a review from j143 April 18, 2026 11:50
@j143
Copy link
Copy Markdown
Owner

j143 commented Apr 19, 2026

@copilot fix the go test issue

172.17.0.1 - - [18/Apr/2026:11:32:01 +0000] "HEAD /v2/alpine/blobs/sha256:3cb067eab609612d81b4d82ff8ad71d73482bb3059a87b642d7e14f0ed659cde HTTP/1.1" 200 0 "" "docker/28.0.4 go/go1.23.7 git-commit/6430e49 kernel/6.17.0-1010-azure os/linux arch/amd64 UpstreamClient(Docker-Client/28.0.4 \(linux\))"
172.17.0.1 - - [18/Apr/2026:11:32:01 +0000] "PUT /v2/alpine/manifests/latest HTTP/1.1" 201 0 "" "docker/28.0.4 go/go1.23.7 git-commit/6430e49 kernel/6.17.0-1010-azure os/linux arch/amd64 UpstreamClient(Docker-Client/28.0.4 \(linux\))"
Verifying the image in the local registry...
Registry catalog: {"repositories":["alpine"]}
Environment detected: inContainer=false, hasNamespacePrivileges=true, hasCgroupAccess=true, cgroupVersion=2
Fetching image 'user:password@localhost:5000/alpine' from registry...
[DEBUG] Starting to pull image 'alpine'
[DEBUG] Fetching manifest for repo 'alpine' and tag 'latest'
Error: Failed to fetch image 'user:password@localhost:5000/alpine': failed to fetch manifest: failed to fetch manifest: Get "***localhost:5000/v2/alpine/manifests/latest": http: server gave HTTP response to HTTPS client
Error: basic-docker failed to run the image.
Cleaning up...
Cleanup completed.

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 19, 2026

@copilot fix the go test issue

172.17.0.1 - - [18/Apr/2026:11:32:01 +0000] "HEAD /v2/alpine/blobs/sha256:3cb067eab609612d81b4d82ff8ad71d73482bb3059a87b642d7e14f0ed659cde HTTP/1.1" 200 0 "" "docker/...

Fixed in b439617 (plus extra coverage in ab520af). resolveRegistry now strips credentials before host detection, so user:pass@localhost:5000/... is treated as a local registry and uses http://localhost:5000/v2/ instead of HTTPS. I also added tests for credentialed local registry cases (including @ in username).

Copilot finished work on behalf of j143 April 19, 2026 06:51
Copilot AI requested a review from j143 April 19, 2026 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants