Force TSG ID to be string, add helm unit-tests#793
Merged
SgtCoDFish merged 3 commits intomasterfrom Apr 22, 2026
Merged
Conversation
Signed-off-by: Ashley Davis <ashley.davis@cyberark.com>
I mostly wanted to add tests for the TSG ID, but there are plenty of tests here which are going to be useful and shouldn't cause any harm Signed-off-by: Ashley Davis <ashley.davis@cyberark.com>
inteon
reviewed
Apr 22, 2026
| - it: should set default minAvailable when no disruption values are set | ||
| set: | ||
| config.clusterName: test-cluster | ||
| config.tsgID: "123456" |
Contributor
There was a problem hiding this comment.
Hmmmm, for enterprise-issuer and distributed-issuer we were using "tsgid" and "clientId" intead of "tsgID" and "clientID". We might have to switch ....
Contributor
Author
There was a problem hiding this comment.
Thanks for pointing that out - definitely worth thinking about. Since the old venafi-kubernetes-agent chart supported clientId I've added support for that form in the latest commit I've pushed.
inteon
approved these changes
Apr 22, 2026
This allows easier migration from the old chart, while also allowing a more consistent style with initialisms Signed-off-by: Ashley Davis <ashley.davis@cyberark.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows a similar change by @inteon in the Firefly Helm chart.
Allowing numbers can cause issues with scientific notation because of YAML's weirdness.
This PR also adds a plethora of helm unit tests - mostly, I just wanted to add a test for TSG IDs but I let claude generate a bunch more. I think the tests add some value, and it's better to have them than not.