Open
Conversation
Member
|
Will, look closer in a bit. For now why not |
Contributor
Author
|
Member
|
Think path fit better and we don't introduce a new annotation. |
Member
|
The router generators:
|
jknack
reviewed
Apr 20, 2026
| super(context, clazz); | ||
| } | ||
|
|
||
| public static WsRouter parse(MvcContext context, TypeElement controller) { |
Member
There was a problem hiding this comment.
here is your parse/selection method. Here you need to filter by Path + [WebSocket] annotation. Is Path required??
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So,
Will produce
and can be registered over
{ ws(new ChatWebsocketWs_()); }Annotation name is
@WebSocketRouteto avoid the clash withio.jooby.WebSocketinterface.If we want a nice annotation like
@WebSocket-> need to renameio.jooby.WebSocketintoio.jooby.WebSocketConnectionor something.