Conversation
Fixes an `IllegalStateException: UT000091: Buffer has already been freed` that occurs during server teardown in gRPC tests. When raw request or response channels are acquired, Undertow shifts the exchange lifecycle management to the channels. Explicitly invoking `exchange.endExchange()` prematurely frees the pooled ByteBuffers. During server shutdown, the HTTP/2 `FrameCloseListener` attempts to gracefully close the connection and release the same buffers, resulting in a race condition and the subsequent exception. Removed explicit `exchange.endExchange()` calls when streams are active in `UndertowGrpcExchange` and `UndertowGrpcInputBridge`. Replaced them with XNIO's `IoUtils.safeClose(channel)`, allowing Undertow's internal state machine to naturally flush, close, and terminate the exchange.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an
IllegalStateException: UT000091: Buffer has already been freedthat occurs during server teardown in gRPC tests.When raw request or response channels are acquired, Undertow shifts the exchange lifecycle management to the channels. Explicitly invoking
exchange.endExchange()prematurely frees the pooled ByteBuffers. During server shutdown, the HTTP/2FrameCloseListenerattempts to gracefully close the connection and release the same buffers, resulting in a race condition and the subsequent exception.Removed explicit
exchange.endExchange()calls when streams are active inUndertowGrpcExchangeandUndertowGrpcInputBridge. Replaced them with XNIO'sIoUtils.safeClose(channel), allowing Undertow's internal state machine to naturally flush, close, and terminate the exchange.