fix: cap popup width on tablets and large screens#521
Open
TomasULR wants to merge 1 commit intokavishdevar:mainfrom
Open
fix: cap popup width on tablets and large screens#521TomasULR wants to merge 1 commit intokavishdevar:mainfrom
TomasULR wants to merge 1 commit intokavishdevar:mainfrom
Conversation
On tablets in landscape mode, the AirPods connection popup covers the entire screen because width is set to MATCH_PARENT. This caps the popup width to 400dp on screens wider than 600dp and centers it horizontally. Also removes a duplicate gravity assignment in init that was overwriting the CENTER_HORIZONTAL flag. Fixes kavishdevar#425
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MATCH_PARENTgravityassignment ininitwas overwriting theCENTER_HORIZONTALflag set in the LayoutParams initializerChanges
PopupWindow.kt: Added screen width detection usingdisplayMetrics, caps width to 400dp on large screensGravity.BOTTOMtoGravity.BOTTOM or Gravity.CENTER_HORIZONTALmParams.gravity = Gravity.BOTTOMininitblockFixes #425