Skip to content

IPv6 bracketed address not functional when used on client side Linux/macOS #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cosminpolifronie wants to merge 4 commits into
base: master
Choose a base branch
from
Open

IPv6 bracketed address not functional when used on client side Linux/macOS #571

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8942cf6
Fix bug where bracketed IPv6 will fail to parse - e.g. [::1]:9001
cosminpolifronie Apr 18, 2026
d71fc84
Fix issue where client couldn't connect via IPv6 bracketed address, e…
cosminpolifronie Apr 18, 2026
4303a37
Refactor clParseURL::ParseURL function and implement multiple malform…
cosminpolifronie Apr 18, 2026
3e86cc8
Fix old remaining FIXME where too small of a buffer was used for IPv6…
cosminpolifronie Apr 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions ixwebsocket/IXSocketServer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,9 +308,11 @@ namespace ix
}

// Accept a connection.
// FIXME: Is this working for ipv6 ?
struct sockaddr_in client; // client address information
int clientFd; // socket connected to client
// Use sockaddr_storage to accommodate both AF_INET and AF_INET6 addresses.
// sockaddr_in is only 16 bytes; sockaddr_in6 is 28 bytes. On Windows, passing
// a too-small buffer to accept() causes WSAEFAULT (error 10014).
struct sockaddr_storage client; // client address information (IPv4 or IPv6)
int clientFd; // socket connected to client
socklen_t addressLen = sizeof(client);
memset(&client, 0, sizeof(client));

Expand Down Expand Up @@ -347,7 +349,8 @@ namespace ix
if (_addressFamily == AF_INET)
{
char remoteIp4[INET_ADDRSTRLEN];
if (ix::inet_ntop(AF_INET, &client.sin_addr, remoteIp4, INET_ADDRSTRLEN) == nullptr)
auto* client4 = reinterpret_cast<struct sockaddr_in*>(&client);
if (ix::inet_ntop(AF_INET, &client4->sin_addr, remoteIp4, INET_ADDRSTRLEN) == nullptr)
{
int err = Socket::getErrno();
std::stringstream ss;
Expand All @@ -360,13 +363,14 @@ namespace ix
continue;
}

remotePort = ix::network_to_host_short(client.sin_port);
remotePort = ix::network_to_host_short(client4->sin_port);
remoteIp = remoteIp4;
}
else // AF_INET6
{
char remoteIp6[INET6_ADDRSTRLEN];
if (ix::inet_ntop(AF_INET6, &client.sin_addr, remoteIp6, INET6_ADDRSTRLEN) ==
auto* client6 = reinterpret_cast<struct sockaddr_in6*>(&client);
if (ix::inet_ntop(AF_INET6, &client6->sin6_addr, remoteIp6, INET6_ADDRSTRLEN) ==
nullptr)
{
int err = Socket::getErrno();
Expand All @@ -380,7 +384,7 @@ namespace ix
continue;
}

remotePort = ix::network_to_host_short(client.sin_port);
remotePort = ix::network_to_host_short(client6->sin6_port);
remoteIp = remoteIp6;
}

Expand Down
Loading