fix(url-rewrite): prevent ArgumentCountError on empty spread in array_merge#40665
Open
lbajsarowicz wants to merge 2 commits intomagento:2.4-developfrom
Open
fix(url-rewrite): prevent ArgumentCountError on empty spread in array_merge#40665lbajsarowicz wants to merge 2 commits intomagento:2.4-developfrom
lbajsarowicz wants to merge 2 commits intomagento:2.4-developfrom
Conversation
…_merge In PHP 8, array_merge() requires at least one argument. When $entities is empty, the spread operator (...$entities) passes zero arguments, causing ArgumentCountError. Prepend an empty array as the first argument to array_merge() so it always receives at least one argument regardless of whether $entities has values. Fixes magento#39579
|
Hi @lbajsarowicz. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
Contributor
Author
|
@magento run all tests |
Two tests verifying array_merge([], ...$entities) handles edge cases: - testReplaceWithEmptyUrlsArray: empty input returns empty result - testReplaceWithEmptyRequestPathDoesNotThrowError: URL rewrite with empty request path processes without ArgumentCountError Relates to magento#39579
Contributor
Author
|
@magento run all tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
DbStorage::deleteOldUrls()andDbStorage::checkDuplicates()usearray_merge(...$entities)to flatten the entity request paths. In PHP 8, when$entitiesis empty, the spread operator passes zero arguments toarray_merge(), causing:This occurs when calling
StorageInterface::replace()with URL rewrites that don't exist in the database yet.Fix
Prepend an empty array as the first argument:
array_merge([], ...$entities). This ensuresarray_mergealways receives at least one argument, returning an empty array when$entitiesis empty.Both occurrences (lines 223 and 276) are fixed.
Fixes #39579
Files Changed
app/code/Magento/UrlRewrite/Model/Storage/DbStorage.php— 2 lines changedManual Testing Scenarios
StorageInterface::replace()with a URL rewrite for a non-existing entityArgumentCountErrorthrown fromarray_merge()⭐ Support my work
Do you like the fix? Remember to react with "👍🏻" to get it merged faster,
Then Sponsor me on Github so I can spend more time on fixing issues like this one.
Learn more at https://github.com/sponsors/lbajsarowicz