Skip to content

fix: correct CustomerGirdFilterPool virtualType typo#40672

Open
lbajsarowicz wants to merge 1 commit intomagento:2.4-developfrom
lbajsarowicz:fix/40500-customer-grid-filter-pool-typo
Open

fix: correct CustomerGirdFilterPool virtualType typo#40672
lbajsarowicz wants to merge 1 commit intomagento:2.4-developfrom
lbajsarowicz:fix/40500-customer-grid-filter-pool-typo

Conversation

@lbajsarowicz
Copy link
Copy Markdown
Contributor

Summary

Fixes a typo in CustomerGirdFilterPool virtualType name (missing "d" → should be CustomerGridFilterPool).

Related: #40500, #38244 (both closed without merge)

Changes

  • Renamed CustomerGirdFilterPoolCustomerGridFilterPool
  • Added deprecated backward-compatible alias CustomerGirdFilterPoolCustomerGridFilterPool for third-party modules
  • Updated internal reference to use the corrected name

Test plan

  • Verify Customer grid loads correctly in admin
  • Verify filters work on customer listing page
  • Confirm no DI compilation errors: bin/magento setup:di:compile

⭐ Support my work

Do you like the fix? Remember to react with "👍🏻" to get it merged faster,
Then Sponsor me on Github so I can spend more time on fixing issues like this one.

Learn more at https://github.com/sponsors/lbajsarowicz

…tomerGridFilterPool

The virtualType name had a typo ("Gird" instead of "Grid"). This renames
it to CustomerGridFilterPool and keeps the old name as a deprecated alias
for backward compatibility with third-party modules.
@m2-assistant
Copy link
Copy Markdown

m2-assistant bot commented Apr 9, 2026

Hi @lbajsarowicz. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@lbajsarowicz
Copy link
Copy Markdown
Contributor Author

@magento run all tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant