fix: remove IE/Flash references and fix font MIME types in htaccess#40685
Open
lbajsarowicz wants to merge 1 commit intomagento:2.4-developfrom
Open
fix: remove IE/Flash references and fix font MIME types in htaccess#40685lbajsarowicz wants to merge 1 commit intomagento:2.4-developfrom
lbajsarowicz wants to merge 1 commit intomagento:2.4-developfrom
Conversation
|
Hi @lbajsarowicz. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove references to dead technologies (Internet Explorer, Adobe Flash) and update deprecated font MIME types to IANA-registered standards in
.htaccessfiles.Changes
1. Remove IE
X-UA-Compatibleheader and document modes sectionpub/.htaccesssetsX-UA-Compatible: IE=edgeand includes a largeFilesMatchblock to unset it on non-HTML resources. Internet Explorer is completely end-of-life:X-UA-CompatibleThis removes the header, the FilesMatch exclusion block, and the explanatory comment section (~20 lines).
2. Remove Flash moxieplayer reference
pub/static/.htaccesscontains a rewrite rule formoxieplayer.swf(a Flash-based media player). Adobe Flash reached end-of-life in December 2020 and is blocked by all modern browsers.3. Fix deprecated font MIME types
Both
pub/media/.htaccessandpub/static/.htaccessuse non-standardapplication/x-font-*MIME types for fonts. These are replaced with the IANA-registered types:application/x-font-ttffont/ttfapplication/x-font-otffont/otfapplication/x-font-wofffont/woffapplication/font-woff2font/woff2Updated in both
AddTypedirectives andExpiresByTypedirectives.Files Changed
pub/.htaccess(IE section removal)pub/static/.htaccess(Flash removal + font MIME types)pub/media/.htaccess(font MIME types)⭐ Support my work
Do you like the fix? Remember to react with "👍🏻" to get it merged faster,
Then Sponsor me on Github so I can spend more time on fixing issues like this one.
Learn more at https://github.com/sponsors/lbajsarowicz