Skip to content

Markdown decoder#191

Open
nalbion wants to merge 5 commits intomemspace:masterfrom
nalbion:feature/MarkdownDecoder
Open

Markdown decoder#191
nalbion wants to merge 5 commits intomemspace:masterfrom
nalbion:feature/MarkdownDecoder

Conversation

@nalbion
Copy link
Copy Markdown

@nalbion nalbion commented Oct 24, 2019

I have implemented the _NotusMarkdownDecoder but can not figure out how to nest blocks within block quotes - it is possible in Markdown, but does Notus have that capability? If so, how?

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 24, 2019

Codecov Report

❌ Patch coverage is 96.47059% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.04%. Comparing base (7f102b9) to head (06c4ebc).
⚠️ Report is 152 commits behind head on master.

Files with missing lines Patch % Lines
packages/notus/lib/src/convert/markdown.dart 96.47% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #191      +/-   ##
==========================================
+ Coverage   90.63%   91.04%   +0.40%     
==========================================
  Files          12       12              
  Lines        1089     1172      +83     
==========================================
+ Hits          987     1067      +80     
- Misses        102      105       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@winwisely99
Copy link
Copy Markdown

@pulyaevskiy Any chance this can start to get reviewed

We are using zefyr heavily for our project and want to help get the Markdown encode and decode cycle working and so hoping a base approach like this can get mainlined so that we are others can contribute

@winwisely99
Copy link
Copy Markdown

@pulyaevskiy Also there are forked now way ahead of Master.

https://github.com/memspace/zefyr/network

Such as:
https://github.com/Yom3n/zefyr

sort of worried this is going to splinter.

@hallidev
Copy link
Copy Markdown

I'll just throw in my hat and say that I'd much appreciate this PR getting merged as well

@CanRau
Copy link
Copy Markdown
Contributor

CanRau commented Feb 24, 2020

Would be amazing to have md support 🎉 👏

@CanRau
Copy link
Copy Markdown
Contributor

CanRau commented Feb 24, 2020

@nalbion does it already handle images? can't get them to work using your fork locally

@rachitgambhir
Copy link
Copy Markdown

rachitgambhir commented Apr 2, 2020

Please review this change !! .. It will be great to have MD support on this editor

@SimonIT
Copy link
Copy Markdown

SimonIT commented Apr 5, 2020

I would love to see this PR merged.

I tried to use this with this md:

*   [ ] User Management
*   [ ] ApiClients
*   [ ] Settings

but I get this error: Style cannot be applied to this leaf node: {block: ul} 'package:notus/src/document/leaf.dart': Failed assertion: line 106 pos 12: 'value != null && (value.isInline || value.isEmpty)'

@andrewpmoore
Copy link
Copy Markdown

If I added your changes to a forked version of notus, how would I go about getting the zefyr to detect when you input the markdown text?

@arpitjacob
Copy link
Copy Markdown

When can we expect this? its stopping me from implementing zefyr in my app.

@ambrose-gladwell-sonocent
Copy link
Copy Markdown

I have implemented the _NotusMarkdownDecoder but can not figure out how to nest blocks within block quotes - it is possible in Markdown, but does Notus have that capability? If so, how?

Hi @nalbion you can only nest headers and inline styles inside blockquotes rather than blocks in Zefyr at the moment.

@vishnukumarra
Copy link
Copy Markdown

When can we expect this? its stopping me from implementing zefyr in my app.

Same situation here .

@stuartwk
Copy link
Copy Markdown

Same situation, will this get merged in?

@nalbion
Copy link
Copy Markdown
Author

nalbion commented May 28, 2020

@ambrose-gladwell-sonocent there's a PR in Delta to support nested formatting - slab/delta#48

@TimWhiting
Copy link
Copy Markdown

Also interested

@boinxi
Copy link
Copy Markdown

boinxi commented Jul 2, 2020

interested as well.

@arpitjacob
Copy link
Copy Markdown

Don't think project is active anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.