Fix CmdPal_DockConfiguration telemetry event never firing#47028
Open
Fix CmdPal_DockConfiguration telemetry event never firing#47028
Conversation
DockViewModel.EmitDockConfiguration() fires a TelemetryDockConfigurationMessage in its constructor, but TelemetryForwarder (which listens for that message) is lazily constructed by DI and may not exist yet. WeakReferenceMessenger silently drops messages with no registered recipient. Fix: Add ITelemetryService as a constructor dependency of DockViewModel. This forces DI to resolve TelemetryForwarder first, ensuring its message listeners are registered before EmitDockConfiguration() fires. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
michaeljolley
added
the
Product-Command Palette
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
The \CmdPal_DockConfiguration\ telemetry event is never received in the data pipeline.
Root Cause
\DockViewModel\ fires a \TelemetryDockConfigurationMessage\ via \WeakReferenceMessenger\ in its constructor. However, \TelemetryForwarder\ — the recipient that forwards this to \PowerToysTelemetry\ — is registered as a lazy DI singleton (\ITelemetryService). If nothing has resolved \ITelemetryService\ before \DockViewModel\ is constructed, \TelemetryForwarder\ doesn't exist yet and the message is silently dropped.
Fix
Add \ITelemetryService\ as a constructor dependency of \DockViewModel. DI is forced to construct \TelemetryForwarder\ (and register its message listeners) before \DockViewModel's constructor runs.
Changes