Skip to content

Remove now unused ChatSessionChangedFile interface#308636

Merged
mjbvz merged 1 commit intomicrosoft:mainfrom
mjbvz:dev/mjbvz/secondary-beaver
Apr 8, 2026
Merged

Remove now unused ChatSessionChangedFile interface#308636
mjbvz merged 1 commit intomicrosoft:mainfrom
mjbvz:dev/mjbvz/secondary-beaver

Conversation

@mjbvz
Copy link
Copy Markdown
Collaborator

@mjbvz mjbvz commented Apr 8, 2026

ChatSessionChangedFile2 can become ChatSessionChangedFile and we can remove the old ChatSessionChangedFile

`ChatSessionChangedFile2` can become `ChatSessionChangedFile`
Copilot AI review requested due to automatic review settings April 8, 2026 23:24
@mjbvz mjbvz self-assigned this Apr 8, 2026
@mjbvz mjbvz enabled auto-merge April 8, 2026 23:24
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the now-unused ChatSessionChangedFile shape and promotes the newer ChatSessionChangedFile2 structure to be the sole ChatSessionChangedFile type in the chatSessionsProvider proposed API.

Changes:

  • Updates ChatSessionItem.changes to only accept ChatSessionChangedFile[] (removing the union with ChatSessionChangedFile2[]).
  • Removes the deprecated ChatSessionChangedFile definition and renames the ChatSessionChangedFile2 shape to ChatSessionChangedFile.
  • Removes the ChatSessionChangedFile2 export from the ext host API surface.
Show a summary per file
File Description
src/vscode-dts/vscode.proposed.chatSessionsProvider.d.ts Removes deprecated changed-file type and narrows changes to the single updated ChatSessionChangedFile type.
src/vs/workbench/api/common/extHostTypes.ts Drops ChatSessionChangedFile2 runtime type and updates ChatSessionChangedFile to the new constructor/shape.
src/vs/workbench/api/common/extHost.api.impl.ts Stops exporting ChatSessionChangedFile2 via the vscode API object.

Copilot's findings

  • Files reviewed: 2/3 changed files
  • Comments generated: 0

@mjbvz mjbvz merged commit abeb7ce into microsoft:main Apr 8, 2026
27 of 28 checks passed
@vs-code-engineering vs-code-engineering bot added this to the 1.116.0 milestone Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants