fix(filesystem): handle UNC paths on Windows in path validation#3995
Open
Will-hxw wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
fix(filesystem): handle UNC paths on Windows in path validation#3995Will-hxw wants to merge 1 commit intomodelcontextprotocol:mainfrom
Will-hxw wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
UNC paths (e.g. \\192.168.1.1\share\) were failing path validation because path.resolve() strips leading backslashes on Windows. Now UNC paths are detected and handled specially - they bypass path.resolve() and are compared directly after normalization. Fixes Issue modelcontextprotocol#3756
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isPathWithinAllowedDirectoriespath.resolve()which strips leading backslashes on WindowsWhy
UNC paths like \192.168.1.1\share were failing validation because
path.resolve()on Windows converts \server\share to \server\share (single backslash), causing the allowed directory check to fail.Validation
Related
Fixes Issue #3756