Skip to content

Migrate comment.js Vuex store to Pinia#7827

Open
theoholl wants to merge 3 commits intomainfrom
migrate-comment-store-to-pinia
Open

Migrate comment.js Vuex store to Pinia#7827
theoholl wants to merge 3 commits intomainfrom
migrate-comment-store-to-pinia

Conversation

@theoholl
Copy link
Copy Markdown
Contributor

@theoholl theoholl commented Apr 6, 2026

Summary

This PR migrated the comment.js Vuex store to Pinia, following patterns from #7790.

theoholl added 2 commits April 6, 2026 09:46
Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
@theoholl theoholl marked this pull request as ready for review April 6, 2026 13:32
Copy link
Copy Markdown
Member

@grnd-alt grnd-alt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you test this? this breaks reactivity when deleting comments and when loading more comments than on initial fetch

@theoholl
Copy link
Copy Markdown
Contributor Author

Oh shoot, I'll review that. I thought I had tested deleting (adding, referencing, etc.) comments at least but I'll put this PR on hold until I tested more thoroughly.

Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
@theoholl theoholl requested a review from grnd-alt April 16, 2026 09:19
@github-actions
Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants