Open
Conversation
Created init and manifest files
|
|
Added fields in __manifest__.py Created models folder, EstateProperty model with the required fields and imported it in __manifest__.py files
Created data folder and file ir.model.access.csv inside it giving read, write, create and unlink permissions to the group base.group_user
Added views and actions for estate.property. Added a 3 level menu with the basic action Added and improved attributes
Mathilde411
requested changes
Apr 23, 2026
Mathilde411
left a comment
Mathilde411
left a comment
There was a problem hiding this comment.
Good job !
I was kinda nitpicky but this is a good job overall :)
Comment on lines
+1
to
+7
| <odoo> | ||
| <menuitem id="estate_menu_root" name="Estate"> | ||
| <menuitem id="estate_first_level_menu" name="Advertisements"> | ||
| <menuitem id="estate_model_menu_action" action="estate_model_action"/> | ||
| </menuitem> | ||
| </menuitem> | ||
| </odoo> No newline at end of file |
There was a problem hiding this comment.
menus should be in the views dir not in data
Comment on lines
+3
to
+4
| <menuitem id="estate_first_level_menu" name="Advertisements"> | ||
| <menuitem id="estate_model_menu_action" action="estate_model_action"/> |
There was a problem hiding this comment.
XMLids for menus should follow the doc
Suggested change
| <menuitem id="estate_first_level_menu" name="Advertisements"> | |
| <menuitem id="estate_model_menu_action" action="estate_model_action"/> | |
| <menuitem id="estate_menu_advertisement" name="Advertisement"> | |
| <menuitem id="estate_property_menu" action="estate_property_action"/> |
| @@ -0,0 +1,2 @@ | |||
| id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink | |||
| access_estate_property,access_estate_property,model_estate_property,base.group_user,1,1,1,1 No newline at end of file | |||
| @@ -0,0 +1,2 @@ | |||
| id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink | |||
| access_estate_property,access_estate_property,model_estate_property,base.group_user,1,1,1,1 No newline at end of file | |||
| @@ -0,0 +1,2 @@ | |||
| id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink | |||
| access_estate_property,access_estate_property,model_estate_property,base.group_user,1,1,1,1 No newline at end of file | |||
There was a problem hiding this comment.
Just like record rules, access XMLids should be formatted like <model_name>_access_<group_name> (see documentation)
Suggested change
| access_estate_property,access_estate_property,model_estate_property,base.group_user,1,1,1,1 | |
| estate_property_access_user,estate.property.user,model_estate_property,base.group_user,1,1,1,1 |
| 'data/estate_menus.xml', | ||
| ], | ||
| 'license': 'AGPL-3' | ||
| } No newline at end of file |
| 'views/estate_property_views.xml', | ||
| 'data/estate_menus.xml', | ||
| ], | ||
| 'license': 'AGPL-3' |
Author
There was a problem hiding this comment.
It was because I was looking at the other manifest files in the tutorials repo as "inspiration" and they were under that one, but after looking it up it seems I should use LGPL-3 instead.
| 'category': 'Tutorials', | ||
| 'version': '0.1', | ||
| 'application': True, | ||
| 'installable': True, |
There was a problem hiding this comment.
installable is True by default, no need to add it.
| 'version': '0.1', | ||
| 'application': True, | ||
| 'installable': True, | ||
| 'depends': ['base'], |
There was a problem hiding this comment.
Suggested change
| 'depends': ['base'], | |
| 'depends': [ | |
| 'base', | |
| ], |
Doing that allows to know when a dependency was added with a git blame :)
| 'author': "Odoo", | ||
| 'website': "https://www.odoo.com/", | ||
| 'category': 'Tutorials', | ||
| 'version': '0.1', |
There was a problem hiding this comment.
For modules outside of Odoo standard, version should include the Odoo version you are targetting like <odoo major>.<odoo minor>.<module major>.<module minor>.<module patch>
So there it'd be like:
Suggested change
| 'version': '0.1', | |
| 'version': '19.0.0.1.0', |
- Added newlines to the relevant files - Changed license and version - Moved menus form data to views folder - Now follows formatting rules
Added list views to main menu Added form view when creating property Added search views, filters and group
simal-odoo
force-pushed
the
19.0-technical-training-simal
branch
from
0b858e1 to
70fa394
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created init and manifest files