docs: align HTTP client READMEs with stable semantic conventions#1683
Merged
LikeTheSalad merged 1 commit intoopen-telemetry:mainfrom Apr 15, 2026
Merged
Conversation
Document stable HTTP span attributes after verifying exported spans from a sample app. OkHttp3 and HttpUrlConnection instrumentations use the standard HTTP client extractors from OpenTelemetry Instrumentation. Fixes open-telemetry#1393 Contributed by @ashishvz on behalf of Vunet Systems (https://vunetsystems.com/). Made-with: Cursor
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1683 +/- ##
==========================================
- Coverage 62.09% 62.00% -0.09%
==========================================
Files 159 159
Lines 3411 3411
Branches 345 345
==========================================
- Hits 2118 2115 -3
- Misses 1199 1201 +2
- Partials 94 95 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fractalwrench
approved these changes
Apr 14, 2026
Member
fractalwrench
left a comment
fractalwrench
left a comment
There was a problem hiding this comment.
LGTM - thanks for investigating this.
LikeTheSalad
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We debugged and tested client HTTP spans from a sample app and confirmed the instrumentation stack already emits the latest stable HTTP semantic conventions (for example
http.response.status_code,http.request.method, andurl.full). No code changes were required.This PR only updates READMEs so the documented attribute names match what we saw at runtime:
instrumentation/okhttp3/README.mdinstrumentation/httpurlconnection/README.mdFixes #1393
Verification
See screenshot below: client span attributes from a real request (e.g. HTTPS GET) showing stable keys including
http.response.status_codeand related HTTP / network fields.