samplers/probability/consistent: Deprecate package#8447
Open
sonalgaud12 wants to merge 3 commits intoopen-telemetry:mainfrom
Open
samplers/probability/consistent: Deprecate package#8447sonalgaud12 wants to merge 3 commits intoopen-telemetry:mainfrom
sonalgaud12 wants to merge 3 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8447 +/- ##
=======================================
- Coverage 82.3% 82.2% -0.1%
=======================================
Files 181 179 -2
Lines 13699 13728 +29
=======================================
+ Hits 11278 11296 +18
- Misses 2023 2034 +11
Partials 398 398
🚀 New features to boost your workflow:
|
Contributor
Author
|
@dmathieu I was confused whether to add a deprecated comment in all the func cause in this case, we are trying to deprecate the whole package, not just a function. So tell me know what else to add or remove |
Contributor
|
I think you want to deprecate the module: https://go.dev/ref/mod#go-mod-file-module-deprecation and the package, but not all of the artifacts in it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecated the samplers/probability/consistent package
Related: #8006