Skip to content

samplers/probability/consistent: Deprecate package#8447

Open
sonalgaud12 wants to merge 3 commits intoopen-telemetry:mainfrom
sonalgaud12:sampler
Open

samplers/probability/consistent: Deprecate package#8447
sonalgaud12 wants to merge 3 commits intoopen-telemetry:mainfrom
sonalgaud12:sampler

Conversation

@sonalgaud12
Copy link
Copy Markdown
Contributor

@sonalgaud12 sonalgaud12 commented Jan 22, 2026

Deprecated the samplers/probability/consistent package

Related: #8006

@sonalgaud12 sonalgaud12 requested a review from a team as a code owner January 22, 2026 07:28
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.2%. Comparing base (6f2cdf6) to head (e149f0f).
⚠️ Report is 22 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #8447     +/-   ##
=======================================
- Coverage   82.3%   82.2%   -0.1%     
=======================================
  Files        181     179      -2     
  Lines      13699   13728     +29     
=======================================
+ Hits       11278   11296     +18     
- Misses      2023    2034     +11     
  Partials     398     398             
Files with missing lines Coverage Δ
samplers/probability/consistent/sampler.go 100.0% <ø> (ø)

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonalgaud12
Copy link
Copy Markdown
Contributor Author

@dmathieu I was confused whether to add a deprecated comment in all the func cause in this case, we are trying to deprecate the whole package, not just a function. So tell me know what else to add or remove

@dashpole
Copy link
Copy Markdown
Contributor

I think you want to deprecate the module: https://go.dev/ref/mod#go-mod-file-module-deprecation and the package, but not all of the artifacts in it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants