[AI-FSSDK] [FSSDK-12368] Cleanup flag base setup (local holdouts)#507
Open
[AI-FSSDK] [FSSDK-12368] Cleanup flag base setup (local holdouts)#507
Conversation
Remove deprecated flag-level holdout functionality as cleanup after local holdouts (FSSDK-12369) implementation. Changes: - Removed includedFlags and excludedFlags from Holdout entity - Removed includedFlags and excludedFlags from HoldoutDict type - Removed get_holdouts_for_flag() method from ProjectConfig - Removed flag-level holdout infrastructure: - global_holdouts list - included_holdouts dict - excluded_holdouts dict - flag_holdouts_map dict - Flag-level population logic in ProjectConfig.__init__ - Removed flag-level holdout checking from DecisionService.get_variation_for_feature() - Removed 10 test methods testing removed functionality - Removed includedFlags/excludedFlags from all test fixtures Impact: 7 files modified, 310 lines deleted, 5 lines added (net: -305 lines) Verification: - grep for "includedFlags", "excludedFlags", "getHoldoutsForFlag" returns zero results - grep for "global_holdouts", "included_holdouts", "excluded_holdouts", "flag_holdouts_map" returns zero results Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes legacy flag-level holdout fields from the SDK as cleanup after local holdouts (FSSDK-12369) implementation.
Jira Ticket: FSSDK-12368
Changes
Step 1: Remove Legacy Fields ✅
includedFlagsandexcludedFlagsfromHoldout.__init__()HoldoutDicttype definitionStep 2: Remove Legacy Methods ✅
get_holdouts_for_flag()method fromProjectConfigglobal_holdoutslistincluded_holdoutsdictexcluded_holdoutsdictflag_holdouts_mapdict__init__DecisionService.get_variation_for_feature()Step 3: Update Tests ✅
test_config.pytest_decision_service_holdout.pyincludedFlagsandexcludedFlagsfrom all test fixturesVerification
✅
grep -r "includedFlags\|excludedFlags" --include="*.py"returns zero results✅
grep -r "getHoldoutsForFlag\|get_holdouts_for_flag" --include="*.py"returns zero results✅
grep -r "global_holdouts\|included_holdouts\|excluded_holdouts\|flag_holdouts_map" --include="*.py"returns zero results✅ All deprecated fields/methods completely removed from codebase
Impact
Test Plan
🤖 Generated with Claude Code