Skip to content

Adds rules to ignore untracked content#74

Open
CullenSharp wants to merge 1 commit intomasterfrom
add-ignore-rule-to-submodules
Open

Adds rules to ignore untracked content#74
CullenSharp wants to merge 1 commit intomasterfrom
add-ignore-rule-to-submodules

Conversation

@CullenSharp
Copy link
Copy Markdown
Contributor

@CullenSharp CullenSharp commented Apr 7, 2026

Simply adds a rule so that untracked content is ignored in repos we don't own (i.e. omap image builder and beagle board device trees)

@CullenSharp CullenSharp force-pushed the add-ignore-rule-to-submodules branch from fbf0e66 to 30c2212 Compare April 7, 2026 19:23
@CullenSharp CullenSharp requested a review from ThirteenFish April 7, 2026 19:25
Copy link
Copy Markdown
Contributor

@ThirteenFish ThirteenFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is fine, I don't hate it, but I like the idea better of cleaning up after ourselves in the build rules, so like the dtb make would have:

@cp $< $(REPO)/$(SRC_PATH)/
...
@rm  $(REPO)/$(SRC_PATH)/$<

and similarly symmetric cp/rms in the build_image script.

This effectively moves the rm up and out of the clean rule too.

This way we leave the submodules pristine and know we didn't accidentally leave any residual configs behind.

@CullenSharp
Copy link
Copy Markdown
Contributor Author

CullenSharp commented Apr 13, 2026

Got it, I'll get to work on this ASAP. Gonna use this as an excuse to improve the makefile in general.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants