Open
Conversation
fbf0e66 to
30c2212
Compare
ThirteenFish
requested changes
Apr 13, 2026
Contributor
ThirteenFish
left a comment
There was a problem hiding this comment.
So this is fine, I don't hate it, but I like the idea better of cleaning up after ourselves in the build rules, so like the dtb make would have:
@cp $< $(REPO)/$(SRC_PATH)/
...
@rm $(REPO)/$(SRC_PATH)/$<
and similarly symmetric cp/rms in the build_image script.
This effectively moves the rm up and out of the clean rule too.
This way we leave the submodules pristine and know we didn't accidentally leave any residual configs behind.
Contributor
Author
|
Got it, I'll get to work on this ASAP. Gonna use this as an excuse to improve the makefile in general. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simply adds a rule so that untracked content is ignored in repos we don't own (i.e. omap image builder and beagle board device trees)