Move static resources to the public directory#125
Open
giroletm wants to merge 1 commit intopluginsGLPI:mainfrom
Open
Move static resources to the public directory#125giroletm wants to merge 1 commit intopluginsGLPI:mainfrom
giroletm wants to merge 1 commit intopluginsGLPI:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting GLPI 11.0.0, static resources for plugins must be placed in the
publicdirectory.The resources pointed by the
Hooks::ADD_JAVASCRIPT,Hooks::ADD_CSS,Hooks::ADD_CSS_ANONYMOUS_PAGE,Hooks::ADD_JAVASCRIPT_MODULE_ANONYMOUS_PAGEandHooks::ADD_JAVASCRIPT_ANONYMOUS_PAGEare static resources and are therefore affected by this change.As a result, loading the example plugin in its current state in the latest version of GLPI (11.0.6 as of writing) results in the requests that try to fetch its CSS and JS files to return a 404.
This PR moves these files in the
publicfolder in order to fix it.