Fix: table rename aborts when GenericObject migration exceeds MySQL's…#1185
Open
Fix: table rename aborts when GenericObject migration exceeds MySQL's…#1185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… 64-char limit
Checklist before requesting a review
Please delete options that are not relevant.
Description
When migrating containers from GenericObject to GlpiCustomAsset, the plugin renames the underlying DB table. For certain object names, the new name exceeds MySQL's 64-character identifier limit, aborting the
migration with error 1059.
A naive table name truncation would not suffice: GLPI derives table names from class names at runtime, so the stored container name and the DB table must stay in sync. The fix truncates the container name until
the generated table fits within 64 chars, then persists the shortened name to the DB — mirroring an identical safeguard already present in installUserData.
Screenshots (if appropriate):