Refactor graph traversal methods to use new computeTraversalPartitions API#3753
Open
clementleclercRTE wants to merge 31 commits intomainfrom
Open
Refactor graph traversal methods to use new computeTraversalPartitions API#3753clementleclercRTE wants to merge 31 commits intomainfrom
computeTraversalPartitions API#3753clementleclercRTE wants to merge 31 commits intomainfrom
Conversation
…API. Signed-off-by: Leclerc Clement <clement.leclerc@rte-france.com>
…API. Signed-off-by: Leclerc Clement <clement.leclerc@rte-france.com>
… graph-connected-components # Conflicts: # iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/NodeBreakerTopologyModel.java
flo-dup
requested changes
Feb 3, 2026
rolnico
changed the title
getConnectedComponents …getConnectedComponents API
flo-dup
requested changes
Feb 3, 2026
… traversal components. Signed-off-by: Leclerc Clement <clement.leclerc@rte-france.com>
…Predicate` Signed-off-by: Leclerc Clement <clement.leclerc@rte-france.com>
…` API, and enhance vertex object handling in graph traversal implementations. Signed-off-by: Leclerc Clement <clement.leclerc@rte-france.com>
Signed-off-by: Leclerc Clement <clement.leclerc@rte-france.com>
Signed-off-by: Leclerc Clement <clement.leclerc@rte-france.com>
|
Signed-off-by: Leclerc Clement <clement.leclerc@rte-france.com>
… graph-connected-components
flo-dup
requested changes
Feb 9, 2026
| } | ||
| return TraverseResult.CONTINUE; | ||
| }).forEach(nodes -> { | ||
| CopyOnWriteArrayList<NodeTerminal> terminals = new CopyOnWriteArrayList<>(); |
Collaborator
There was a problem hiding this comment.
I'm wondering if we really need the CopyOnWriteArrayList for buses
…comments Signed-off-by: Leclerc Clement <clement.leclerc@rte-france.com>
…comments Signed-off-by: Leclerc Clement <clement.leclerc@rte-france.com>
… graph-connected-components
Signed-off-by: Leclerc Clement <clement.leclerc@rte-france.com>
flo-dup
requested changes
Feb 23, 2026
Collaborator
flo-dup
left a comment
flo-dup
left a comment
There was a problem hiding this comment.
The naming is questionable, as we're not computing connected component if we rely on graph theory definition. We should rather call it something like computeTraversalPartitions, as we're partitioning the graph (all the vertices are traversed if there's no TERMINATE_TRAVERSER return) based on a given traversal.
… graph-connected-components
… update related tests, topology models, and traversal logic. Signed-off-by: Leclerc Clement <clement.leclerc@rte-france.com>
flo-dup
changed the title
getConnectedComponents APIcomputeTraversalPartitions API
flo-dup
requested changes
Mar 3, 2026
Collaborator
|
Could you also complete the PR description, regarding the migration guide / breaking changes part? |
… graph-connected-components
Signed-off-by: Leclerc Clement <clement.leclerc@rte-france.com>
…nents # Conflicts: # iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/NodeBreakerTopologyModel.java
Signed-off-by: Leclerc Clement <clement.leclerc@rte-france.com>
|
flo-dup
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
What kind of change does this PR introduce?
Refactoring / New API
What is the current behavior?
Currently, BusBreakerTopologyModel, NodeBreakerTopologyModel, and DcTopologyModel all contain duplicated logic to traverse the graph and identify connected components (bus construction).
What is the new behavior (if this is a feature change)?
A new method
computeTraversalPartitionshas been introduced in theUndirectedGraphinterface. It centralizes the graph traversal and connected component building logic, using standardfunctional interfaces (
Supplier,ObjIntConsumer) for flexibility. The three topology models have been refactored to use this shared method.The previously public method
traverse(int, TraversalType, Traverser, boolean[])is now deprecated in favor oftraverse(int, TraversalType, Traverser)andcomputeTraversalPartitions(...).Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
1. Deprecated:
traverse(int, TraversalType, Traverser, boolean[])If you were using this overload to manually track visited vertices, switch to the standard
traverse(int, TraversalType, Traverser)overload. Visited vertices can be captured directly inside yourTraverserlambda.2. Manual connected component computation
If you were manually implementing the traversal-and-partition pattern (iterating over vertices, tracking visited state, grouping results), you can now replace this logic with a call to
computeTraversalPartitions(Traverser)or its generic overloadcomputeTraversalPartitions(Traverser, Supplier<C>, ObjIntConsumer<C>).Other information: