Skip to content

Country / zone diagram#751

Draft
flo-dup wants to merge 5 commits intomainfrom
country_diagram
Draft

Country / zone diagram#751
flo-dup wants to merge 5 commits intomainfrom
country_diagram

Conversation

@flo-dup
Copy link
Copy Markdown
Collaborator

@flo-dup flo-dup commented Nov 6, 2025

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • A PR or issue has been opened in all impacted repositories (if any)

Does this PR already have an issue describing the problem?
No

What kind of change does this PR introduce?
Feature

What is the current behavior?
Only voltage levels graphs could be generated

What is the new behavior (if this is a feature change)?
Country (or zone) graphs could be generated

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Nov 6, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
67.1% Coverage on New Code (required ≥ 90%)

See analysis details on SonarQube Cloud

@flo-dup
Copy link
Copy Markdown
Collaborator Author

flo-dup commented Nov 6, 2025

This has been developped quickly for having a glance of this feature, in order to confirm that users are interested in such a feature.

To do this in a cleaner way,

  • we should refactor the existing code as VoltageLevelNode / BusNode is not appropriate for country / zone diagram
  • the DefaultCountryLabelProvider is coded to have the arrows at the exact same radius for France, this should be an input parameter
  • it would be nice to rely on some geographical position as initial positions for the layout
  • the principle should be extended to group voltage levels based on any grouping method given as input
  • more unit tests are needed

@flo-dup
Copy link
Copy Markdown
Collaborator Author

flo-dup commented Nov 6, 2025

An example for the french neighbouring countries exchanges
image

@alicecaron alicecaron moved this from TODO to In Progress in Release 03/2026 Jan 9, 2026
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
68.0% Coverage on New Code (required ≥ 90%)

See analysis details on SonarQube Cloud

@alicecaron
Copy link
Copy Markdown

We should move some code to core as it is said in this core issue#3758

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

2 participants