Move non-runtime deps to dev/example requirements#19019
Move non-runtime deps to dev/example requirements#19019cdeil wants to merge 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19019
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 4 Unrelated FailuresAs of commit 1b7da2b with merge base ccaf17e ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
There was a problem hiding this comment.
Pull request overview
This PR trims non-runtime Python dependencies from the published executorch wheel metadata, continuing the effort from #15379 / #18188 to keep downstream installs lightweight by moving test- and example-only packages out of [project].dependencies.
Changes:
- Move
expecttest,hypothesis,kgb, andparameterizedfrompyproject.tomlruntime dependencies intorequirements-dev.txt. - Move
scikit-learnfrom runtime dependencies intorequirements-examples.txt(it’s only imported by example scripts). - Drop the direct
mpmath==1.3.0runtime pin (no in-tree direct imports;sympyremains a runtime dependency).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
requirements-examples.txt |
Adds scikit-learn to the examples requirements to support example-only imports. |
requirements-dev.txt |
Adds test-only dependencies needed by the repo’s test suite/tooling tests. |
pyproject.toml |
Removes non-runtime dependencies from wheel metadata and drops the direct mpmath pin. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Follow up to #15379 and #18188 by trimming more non-runtime dependencies from the published
executorchwheel metadata.cc @jackzhxng and @mergennachin since you commented/merged the related issue/PR.
expecttest,hypothesis,kgb, andparameterizedout of[project].dependenciesand intorequirements-dev.txt, since they are only used by tests.scikit-learntorequirements-examples.txt, since the in-tree uses are example scripts rather than core runtime paths.mpmathruntime pin, sincesympyalready pulls it transitively.This keeps user installs lighter and avoids forcing test/example-only packages into downstream environments.