Skip to content

Move non-runtime deps to dev/example requirements#19019

Open
cdeil wants to merge 1 commit intopytorch:mainfrom
cdeil:dev-dep-cleanup
Open

Move non-runtime deps to dev/example requirements#19019
cdeil wants to merge 1 commit intopytorch:mainfrom
cdeil:dev-dep-cleanup

Conversation

@cdeil
Copy link
Copy Markdown

@cdeil cdeil commented Apr 21, 2026

Follow up to #15379 and #18188 by trimming more non-runtime dependencies from the published executorch wheel metadata.

cc @jackzhxng and @mergennachin since you commented/merged the related issue/PR.

  • Move expecttest, hypothesis, kgb, and parameterized out of [project].dependencies and into requirements-dev.txt, since they are only used by tests.
  • Move scikit-learn to requirements-examples.txt, since the in-tree uses are example scripts rather than core runtime paths.
  • Drop the direct mpmath runtime pin, since sympy already pulls it transitively.

This keeps user installs lighter and avoids forcing test/example-only packages into downstream environments.

Copilot AI review requested due to automatic review settings April 21, 2026 12:35
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Apr 21, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19019

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 4 Unrelated Failures

As of commit 1b7da2b with merge base ccaf17e (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 21, 2026
@github-actions
Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR trims non-runtime Python dependencies from the published executorch wheel metadata, continuing the effort from #15379 / #18188 to keep downstream installs lightweight by moving test- and example-only packages out of [project].dependencies.

Changes:

  • Move expecttest, hypothesis, kgb, and parameterized from pyproject.toml runtime dependencies into requirements-dev.txt.
  • Move scikit-learn from runtime dependencies into requirements-examples.txt (it’s only imported by example scripts).
  • Drop the direct mpmath==1.3.0 runtime pin (no in-tree direct imports; sympy remains a runtime dependency).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
requirements-examples.txt Adds scikit-learn to the examples requirements to support example-only imports.
requirements-dev.txt Adds test-only dependencies needed by the repo’s test suite/tooling tests.
pyproject.toml Removes non-runtime dependencies from wheel metadata and drops the direct mpmath pin.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants