Skip to content

NXP backend: Use new Neutron flow for failing constant pad tests.#19024

Open
MartinPavella wants to merge 1 commit intopytorch:mainfrom
nxp-upstream:nxg01483/EIEX-855-test_constant_pad_nd__delegation__formatless__supported_padding-fails-with-ns-3.1.0
Open

NXP backend: Use new Neutron flow for failing constant pad tests.#19024
MartinPavella wants to merge 1 commit intopytorch:mainfrom
nxp-upstream:nxg01483/EIEX-855-test_constant_pad_nd__delegation__formatless__supported_padding-fails-with-ns-3.1.0

Conversation

@MartinPavella
Copy link
Copy Markdown
Collaborator

@MartinPavella MartinPavella commented Apr 21, 2026

Summary

In Neutron SW SDK 3.1.0, some edge cases of the constant pad operator are no longer supported by the old flow. Affected tests now use the new flow where the pad is supported.

(Only the last commit is relevant)

Test plan

Unit tests provided.

cc @robert-kalmar @JakeStevens @digantdesai

@MartinPavella MartinPavella self-assigned this Apr 21, 2026
@MartinPavella MartinPavella added the module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ label Apr 21, 2026
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Apr 21, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19024

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 Cancelled Job, 2 Unrelated Failures

As of commit af106a1 with merge base c8c791a (image):

CANCELLED JOB - The following job was cancelled. Please retry:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 21, 2026
@github-actions
Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@MartinPavella MartinPavella force-pushed the nxg01483/EIEX-855-test_constant_pad_nd__delegation__formatless__supported_padding-fails-with-ns-3.1.0 branch from 065dc35 to af106a1 Compare April 23, 2026 11:32
@MartinPavella MartinPavella marked this pull request as ready for review April 23, 2026 11:32
assert any(node.name == "aten_constant_pad_nd_default" for node in nodes)


@pytest.mark.xfail(reason="EIEX=855")
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parametrize the test to it for legacy and new flow. Those two are distinct and the new mlir flow is experimental, hence the EIEX-855 is still valid.

Yes, eventually the EIEX-855 will be closed as outdated, once the mlir flow is mature enough but we are not yet there.
As we will do this for multiple operators define a mlir_flow as default parameter, like for qat - executorch/backends/nxp/tests/use_qat.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants