NXP backend: Use new Neutron flow for failing constant pad tests.#19024
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19024
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 Cancelled Job, 2 Unrelated FailuresAs of commit af106a1 with merge base c8c791a ( CANCELLED JOB - The following job was cancelled. Please retry:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
065dc35 to
af106a1
Compare
| assert any(node.name == "aten_constant_pad_nd_default" for node in nodes) | ||
|
|
||
|
|
||
| @pytest.mark.xfail(reason="EIEX=855") |
There was a problem hiding this comment.
Parametrize the test to it for legacy and new flow. Those two are distinct and the new mlir flow is experimental, hence the EIEX-855 is still valid.
Yes, eventually the EIEX-855 will be closed as outdated, once the mlir flow is mature enough but we are not yet there.
As we will do this for multiple operators define a mlir_flow as default parameter, like for qat - executorch/backends/nxp/tests/use_qat.py
Summary
In Neutron SW SDK 3.1.0, some edge cases of the constant pad operator are no longer supported by the old flow. Affected tests now use the new flow where the pad is supported.
(Only the last commit is relevant)
Test plan
Unit tests provided.
cc @robert-kalmar @JakeStevens @digantdesai