Switch VGF backend from custom vulkan-headers-1.4.343 to standardized khronos (#19031)#19031
Switch VGF backend from custom vulkan-headers-1.4.343 to standardized khronos (#19031)#19031ocvh wants to merge 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19031
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 3 Unrelated FailuresAs of commit 6a2e535 with merge base 1d37abd ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@ocvh has exported this pull request. If you are a Meta employee, you can view the originating Diff in D100706182. |
This PR needs a
|
|
|
… khronos (pytorch#19031) Summary: Migrate the VGF backend's Vulkan dependencies from the custom `third-party/vulkan-headers-1.4.343` package to the standardized `third-party/khronos` and `third-party/volk` packages. The custom package had a regenerated volk with ARM tensor extensions, but the standard volk and khronos 1.4.341 headers already include these extensions (`VK_ARM_tensors`). Changes: - `targets.bzl`: Replace custom `vulkan-headers-1.4.343` deps with `third-party/volk:volk_src`, `third-party/volk:volk-header`, and `third-party/khronos:vulkan-headers` - `VGFBackend.cpp`, `VGFSetup.h`: Include `<volk.h>` directly instead of going through the `vk_api.h` shim (which just forwarded to volk.h when USE_VULKAN_VOLK is defined) - `third-party/volk/BUCK`: Add `volk_src` export_file target for direct compilation into consumer targets Differential Revision: D100706182
… khronos (pytorch#19031) Summary: Migrate the VGF backend's Vulkan dependencies from the custom `third-party/vulkan-headers-1.4.343` package to the standardized `third-party/khronos` and `third-party/volk` packages. The custom package had a regenerated volk with ARM tensor extensions, but the standard volk and khronos 1.4.341 headers already include these extensions (`VK_ARM_tensors`). Changes: - `targets.bzl`: Replace custom `vulkan-headers-1.4.343` deps with `third-party/volk:volk_src`, `third-party/volk:volk-header`, and `third-party/khronos:vulkan-headers` - `VGFBackend.cpp`, `VGFSetup.h`: Include `<volk.h>` directly instead of going through the `vk_api.h` shim (which just forwarded to volk.h when USE_VULKAN_VOLK is defined) - `third-party/volk/BUCK`: Add `volk_src` export_file target for direct compilation into consumer targets Differential Revision: D100706182
70957b5 to
984c2da
Compare
… khronos (pytorch#19031) Summary: Pull Request resolved: pytorch#19031 Migrate the VGF backend's Vulkan dependencies from the custom `third-party/vulkan-headers-1.4.343` package to the standardized `third-party/khronos` and `third-party/volk` packages. The custom package had a regenerated volk with ARM tensor extensions, but the standard volk and khronos 1.4.341 headers already include these extensions (`VK_ARM_tensors`). Changes: - `targets.bzl`: Replace custom `vulkan-headers-1.4.343` deps with `third-party/volk:volk_src`, `third-party/volk:volk-header`, and `third-party/khronos:vulkan-headers` - `VGFBackend.cpp`, `VGFSetup.h`: Include `<volk.h>` directly instead of going through the `vk_api.h` shim (which just forwarded to volk.h when USE_VULKAN_VOLK is defined) - `third-party/volk/BUCK`: Add `volk_src` export_file target for direct compilation into consumer targets Differential Revision: D100706182
… khronos (pytorch#19031) Summary: Pull Request resolved: pytorch#19031 Migrate the VGF backend's Vulkan dependencies from the custom `third-party/vulkan-headers-1.4.343` package to the standardized `third-party/khronos` and `third-party/volk` packages. The custom package had a regenerated volk with ARM tensor extensions, but the standard volk and khronos 1.4.341 headers already include these extensions (`VK_ARM_tensors`). Changes: - `targets.bzl`: Replace custom `vulkan-headers-1.4.343` deps with `third-party/volk:volk_src`, `third-party/volk:volk-header`, and `third-party/khronos:vulkan-headers` - `VGFBackend.cpp`, `VGFSetup.h`: Include `<volk.h>` directly instead of going through the `vk_api.h` shim (which just forwarded to volk.h when USE_VULKAN_VOLK is defined) - `third-party/volk/BUCK`: Add `volk_src` export_file target for direct compilation into consumer targets Differential Revision: D100706182
Summary:
Migrate the VGF backend's Vulkan dependencies from the custom
third-party/vulkan-headers-1.4.343package to the standardizedthird-party/khronosandthird-party/volkpackages. The custom package had a regenerated volk with ARM tensor extensions, but the standard volk and khronos 1.4.341 headers already include these extensions (VK_ARM_tensors).Changes:
targets.bzl: Replace customvulkan-headers-1.4.343deps withthird-party/volk:volk_src,third-party/volk:volk-header, andthird-party/khronos:vulkan-headersVGFBackend.cpp,VGFSetup.h: Include<volk.h>directly instead of going through thevk_api.hshim (which just forwarded to volk.h when USE_VULKAN_VOLK is defined)third-party/volk/BUCK: Addvolk_srcexport_file target for direct compilation into consumer targetsDifferential Revision: D100706182