Skip to content

Add tryTo evalue accessors #19039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lucylq wants to merge 6 commits into
base: main
Choose a base branch
from
+444 −0
Open

Add tryTo evalue accessors #19039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c86a94e
Update
Apr 22, 2026
3bbed22
Update
Apr 22, 2026
d608c49
Update
Apr 22, 2026
4237e55
Update
Apr 22, 2026
8427c1b
Update
Apr 22, 2026
5c4e010
Update
Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions runtime/core/evalue.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@

namespace executorch {
namespace runtime {

// Specialize for list of optional tensors, as nullptr is a valid std::nullopt.
// For non-optional types, nullptr is invalid.

template <>
executorch::aten::ArrayRef<std::optional<executorch::aten::Tensor>>
BoxedEvalueList<std::optional<executorch::aten::Tensor>>::get() const {
Expand All @@ -27,5 +31,26 @@ BoxedEvalueList<std::optional<executorch::aten::Tensor>>::get() const {
return executorch::aten::ArrayRef<std::optional<executorch::aten::Tensor>>{
unwrapped_vals_, wrapped_vals_.size()};
}

template <>
Result<executorch::aten::ArrayRef<std::optional<executorch::aten::Tensor>>>
BoxedEvalueList<std::optional<executorch::aten::Tensor>>::tryGet() const {
for (typename executorch::aten::ArrayRef<
std::optional<executorch::aten::Tensor>>::size_type i = 0;
i < wrapped_vals_.size();
i++) {
if (wrapped_vals_[i] == nullptr) {
unwrapped_vals_[i] = std::nullopt;
continue;
}
auto r = wrapped_vals_[i]->tryToOptional<executorch::aten::Tensor>();
if (!r.ok()) {
return r.error();
}
unwrapped_vals_[i] = std::move(r.get());
}
return executorch::aten::ArrayRef<std::optional<executorch::aten::Tensor>>{
unwrapped_vals_, wrapped_vals_.size()};
}
} // namespace runtime
} // namespace executorch
Loading
Loading