Open
Conversation
…ission, 6 meters on 115kbaud was reached. - -1 (minus one) was returned in some functions from usb_cdc.c, returning uint8_t, so warning was emitted by the compiler, I fix it by changing their result type to int and verify error on calling side.
Owner
|
Sorry for a huge delay and thank you for your contribution. Everything looks solid and I'm open to accepting this PR once we deal with a couple of minor issues. Please see code comments. Kudos for the bug fixes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added IrDA support. I am planning to add not UART IrDA devices support (IrDA remote control for TV or air conditioner for example), but now it's the first step.