feat(gcs): Allow custom public URL for GoogleCloudStorageAdapter#1891
Open
QDenka wants to merge 1 commit intothephpleague:3.xfrom
Open
feat(gcs): Allow custom public URL for GoogleCloudStorageAdapter#1891QDenka wants to merge 1 commit intothephpleague:3.xfrom
QDenka wants to merge 1 commit intothephpleague:3.xfrom
Conversation
Adds an optional `publicUrl` constructor parameter to override the default `https://storage.googleapis.com` base URL used when generating public URLs. When a custom URL is provided, the bucket name is omitted from the generated URL (assuming the custom domain already maps to the correct bucket). Closes thephpleague#1878
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an optional
publicUrlconstructor parameter toGoogleCloudStorageAdapterto override the defaulthttps://storage.googleapis.combase URL used when generating public URLs.Motivation
Google Cloud Storage supports custom domains for buckets. Currently the public URL is hardcoded, making it impossible to use a custom domain.
Closes #1878
Changes
publicUrlparameter to the constructor