Only look for old Linux kernel versions on Linux.#2031
Open
petterreinholdtsen wants to merge 1 commit intouxlfoundation:masterfrom
Open
Only look for old Linux kernel versions on Linux.#2031petterreinholdtsen wants to merge 1 commit intouxlfoundation:masterfrom
petterreinholdtsen wants to merge 1 commit intouxlfoundation:masterfrom
Conversation
petterreinholdtsen
force-pushed
the
hurd-no-linux-version
branch
3 times, most recently
from
02035fe to
a06d35e
Compare
This do not work well on GNU Hurd, where the kernel version is 0.9. This get test_malloc_compliance working on GNU Hurd. This fix is related to uxlfoundation#2027.
petterreinholdtsen
force-pushed
the
hurd-no-linux-version
branch
from
a06d35e to
31fc41a
Compare
Contributor
Author
|
[Alexandr-Konovalov]
Logic in the legacy is "size must be non-zero, except for VmPeak and
really old Linux". And what is your assumption? Why you think is it
reasonable to drop this check in every case?
My assumtion was that this was a check that was intended for Linux only.
I read from your message that only the latter part was for Linux only,
and have changed the commit to better reflect what I suspect is the
change you recommend.
…--
Happy hacking
Petter Reinholdtsen
|
petterreinholdtsen
changed the title
Contributor
Your current version assumes that Hurd may not have VmPeak in /proc/*/status. Is it another API go get that info? |
Contributor
Author
|
[Alexandr-Konovalov]
Your current version assumes that Hurd may not have VmPeak in
/proc/*/status. Is it another API go get that info?
I do not understand. The latest edition look like this:
if (stat != peakUsage
#if __linux__
|| LinuxKernelVersion() >= 2006015)
#endif
ASSERT(size, "Invalid /proc/self/status format, pattern not found.");
I understand it to mean that every platform will check peakUsage, but
only old linux plattforms are allowed to skip the test. Are we looking
at the same code?
…--
Happy hacking
Petter Reinholdtsen
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This do not work well on GNU Hurd, where the kernel version is 0.9.
This get test_malloc_compliance working on GNU Hurd.
This fix is related to #2027.
Type of change
Choose one or multiple, leave empty if none of the other choices apply
Add a respective label(s) to PR if you have permissions
Tests
Documentation
Breaks backward compatibility