Skip to content

update #2

Open
windsofchange wants to merge 30 commits intowindsofchange:masterfrom
supportpal:master
Open

update #2
windsofchange wants to merge 30 commits intowindsofchange:masterfrom
supportpal:master

Conversation

@windsofchange
Copy link
Copy Markdown
Owner

No description provided.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 16a28469e5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread index.twig
Comment on lines +327 to +333
{% if auth_user().hasPermission('view.background_jobs') %}
<li aria-haspopup="false">
<a href="{{ route('core.operator.background_jobs') }}">
{{ Lang.get('core.background_jobs') }}
</a>
</li>
{% endif %}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Include the new system permissions in the Utilities guards

Operators who are granted only one of the new permissions (view.background_jobs, view.system_health, or view.systemupdate) will never see these entries in index.twig: the added links are still nested under the older Utilities/System guards that require view.emaillog|view.emailqueue|view.license|view.operatorlog|view.phpinfo|view.activitylog and then view.phpinfo|view.systemcleanup. In that role configuration the pages exist, but there is no navigation path to them unless the user guesses the URL.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants