Add jdt:// URI rewriting for documentation responses#224
Open
tartarughina wants to merge 1 commit intozed-extensions:mainfrom
Open
Add jdt:// URI rewriting for documentation responses#224tartarughina wants to merge 1 commit intozed-extensions:mainfrom
tartarughina wants to merge 1 commit intozed-extensions:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the LSP proxy to resolve jdt:// URIs embedded inside documentation responses, and applies a few performance optimizations along the way.
Problem
Zed cannot open jdt:// URIs. The proxy already rewrites them in textDocument/definition/typeDefinition/implementation responses by fetching the decompiled class via java/classFileContents and exposing it as a temp file. However, JDTLS also embeds jdt:// URIs inside Javadoc markdown (e.g. ArrayList) returned by textDocument/hover, textDocument/signatureHelp, and completionItem/resolve. Those links were unreachable from Zed.
Changes
Feature: rewrite
jdt://URIs in documentation responsesTest
just proxy-installfrom the extension directory.../Zed/extensions/work/java/proxy-binto the most recent version of the proxy ie.mv java-lsp-proxy v6.8.13.1