Recognize .phpt and .stub files as PHP files#116
Recognize .phpt and .stub files as PHP files#116williamdes wants to merge 1 commit intozed-extensions:mainfrom
.phpt and .stub files as PHP files#116Conversation
MrSubidubi
left a comment
There was a problem hiding this comment.
Thanks for this!
While I am down for the phpt extension and I definitely see the value for the stub extension, I feel a bit uneasy about the latter one. Could we in an effort to match the stub files perhaps try to update the first line pattern instead to also catch these? Just as a thought so it is a bit more precise in matching and not having too many false positivies.
Not insisting, would like your opinion here
.phpt and .stub files as PHP files
Well, I read this twice and I am not entirely sure of what I understand |
Here is a random example of a phpt file: https://github.com/yvoyer/domain-event/blob/3.0.0/examples/blog.phpt
And I decided to add stub as a php file too given that most stub files are php files.
https://github.com/search?q=path%3A*.stub+%22%3C%3Fphp%22&type=code