feat(ruby): add Fuzzy Ruby Server language server support#283
Open
candidosales wants to merge 3 commits intozed-extensions:mainfrom
Open
feat(ruby): add Fuzzy Ruby Server language server support#283candidosales wants to merge 3 commits intozed-extensions:mainfrom
candidosales wants to merge 3 commits intozed-extensions:mainfrom
Conversation
…erage - Updated GEM_NAME to a non-empty sentinel value to avoid silent failures in gem operations. - Refactored language_server_binary to separate binary resolution logic for custom paths and PATH lookups. - Added checks for the existence and executability of custom binary paths. - Enhanced testing coverage for language_server_binary, including tests for custom paths, PATH discovery, and error handling. - Introduced new methods in the WorktreeLike trait to facilitate testing. - Documented findings and suggestions for maintainability and reliability improvements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Fuzzy Ruby Server as a supported language server in the Ruby extension. This was requested by the Zed team after closing zed-industries/extensions#5107 — all Ruby language servers should live in this single extension rather than in separate extensions.
Fuzzy Ruby Server is a Rust binary (not a Ruby gem), so its integration intentionally bypasses the bundler/gemset installation logic used by the other language servers.
What's included
fuzzy-ruby-serverinextension.tomlFuzzyRubyServerstruct implementing theLanguageServertrait with a customlanguage_server_binarythat:lsp.fuzzy-ruby-server.binary.pathin Zed settings (with existence validation and a clear error message if the path is invalid)fuzzybinaryWorktreeLikeandFakeWorktreewith awhich()method for testabilityInstallation
Users must install the binary manually:
Or configure an explicit path in Zed settings:
{ "lsp": { "fuzzy-ruby-server": { "binary": { "path": "/path/to/fuzzy" } } } }Test plan
cargo test)fuzzyinstalled and verify completions workfuzzyis not installed