feat(hardare-testing): Inner well geometry creator and validator#18935
Merged
HovanNgoOpentrons merged 139 commits intoedgefrom Sep 22, 2025
Merged
feat(hardare-testing): Inner well geometry creator and validator#18935HovanNgoOpentrons merged 139 commits intoedgefrom
HovanNgoOpentrons merged 139 commits intoedgefrom
Conversation
…ram to labware validator
…+touch tip, other small changes
… changed deck layout
rclarke0
reviewed
Sep 22, 2025
Contributor
rclarke0
left a comment
rclarke0
left a comment
There was a problem hiding this comment.
Looks great and very readable code! just have some minor comments on making things a little clearer
rclarke0
changed the title
rclarke0
added a commit
that referenced
this pull request
Oct 6, 2025
…8935) # Overview Added a protocol `inner_well_geometry_creator`. This protocol essentially allows inner labware definitions to be created using a robot protocol by mapping heights to volumes dispensed. It does this by dispensing a certain amount of liquid in steps, and then probing the liquid surface. At the end of the protocol, it creates a .json that interpolates this height-to-volume map into frustums, which are then placed in the Inner Labware Geometry (IWG) .json and can be used in place of a traditional (Solidworks based) Inner Labware Geometry Definition. Added a `volume-validator` protocol that validates these generated inner labware definitions by determining the error from nominal for specified heights. ## Test Plan and Hands on Testing Tested and validated the protocol across numerous labware types, i.e 384 plates, 96 plates, cuboidal plates, conical plates, etc. Stored and analyzed results in https://docs.google.com/spreadsheets/d/12iuEUkAOHlTU8JP1TbYDwmuGkun2XnJfdUJc6gg3ZuU/edit?gid=166223136#gid=166223136 ## Changelog -Added well-geometry-creator.py -Added volume-validator.py --------- Co-authored-by: ABR <rhyann.clarke@opentrons.com> Co-authored-by: David Gomez <57112633+djgomez-opentrons@users.noreply.github.com> Co-authored-by: Rhyann Clarke <146747548+rclarke0@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Added a protocol
inner_well_geometry_creator. This protocol essentially allows inner labware definitions to be created using a robot protocol by mapping heights to volumes dispensed. It does this by dispensing a certain amount of liquid in steps, and then probing the liquid surface. At the end of the protocol, it creates a .json that interpolates this height-to-volume map into frustums, which are then placed in the Inner Labware Geometry (IWG) .json and can be used in place of a traditional (Solidworks based) Inner Labware Geometry Definition.Added a
volume-validatorprotocol that validates these generated inner labware definitions by determining the error from nominal for specified heights.Test Plan and Hands on Testing
Tested and validated the protocol across numerous labware types, i.e 384 plates, 96 plates, cuboidal plates, conical plates, etc. Stored and analyzed results in https://docs.google.com/spreadsheets/d/12iuEUkAOHlTU8JP1TbYDwmuGkun2XnJfdUJc6gg3ZuU/edit?gid=166223136#gid=166223136
Changelog
-Added well-geometry-creator.py
-Added volume-validator.py